Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement /tmp and /const var decorators on object vars for issaved() #1443

Merged
merged 15 commits into from
Sep 28, 2023
Merged

Implement /tmp and /const var decorators on object vars for issaved() #1443

merged 15 commits into from
Sep 28, 2023

Conversation

amylizzle
Copy link
Contributor

@amylizzle amylizzle commented Sep 1, 2023 •
edited
Loading

Fixes #832
Fixes #1318

wixoaGit
wixoaGit requested changes Sep 1, 2023
View reviewed changes
Content.Tests/DMProject/Tests/Stdlib/issaved.dm Outdated Show resolved Hide resolved
OpenDreamShared/Json/DreamObjectJson.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Objects/DreamObject.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Objects/DreamObjectTree.cs Show resolved Hide resolved
OpenDreamRuntime/Objects/DreamObjectTree.cs Show resolved Hide resolved
@amylizzle amylizzle requested a review from wixoaGit September 17, 2023 10:15
@wixoaGit
Copy link
Member

I profiled Paradise init with this and the HashSet check in DreamObject.SetVar() only took ~68ms.

@wixoaGit wixoaGit merged commit 3ef630f into OpenDreamProject:master Sep 28, 2023
4 checks passed
@amylizzle amylizzle deleted the tmp-and-const-var-decorators branch September 28, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amylizzle @wixoaGit